Uploaded image for project: 'GPII - Global Public Inclusive Infrastructure'
  1. GPII - Global Public Inclusive Infrastructure
  2. GPII-3659

Allow standard login endpoint to log out any currently logged in user

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: Lifecycle Manager
    • Labels:
      None

      Description

      It seems that Gregg has believed for a while that the standard behaviour of any login endpoint is to log out any currently logged in user. This is something that the proximityTriggered endpoint does automatically, but the standard "login" endpoint has various branches which trigger an error.

      This requirement seems to emerge from the following test report forwarded by Javier Hernández which shows under point "J4" that the current behaviour of the login endpoint is considered in error:

      https://docs.google.com/document/d/1MGpFf70ViEZhv34cJmBGB-gv7oSWbIR88-_mHPv0rQ0/edit - "Morphic 1.0.1 Candidate - Reported issues", section from Javi dated 17-Jan-2019 - The system shows the “Ooops. Something went wrong. Try restarting the computer if this problem continues” when trying to key in while there is another user already keyed in.

      Luckily this can be achieved largely through deleting existing code - 

      i) The checks in the UserLogonRequest at https://github.com/GPII/universal/blob/master/gpii/node_modules/lifecycleManager/src/UserLogonRequest.js#L69 which produce this error

      ii) The specific checks for "noUser" in lifecycleManager.performLogin when deciding whether to log out a currently logged in user at https://github.com/GPII/universal/blob/master/gpii/node_modules/lifecycleManager/src/LifecycleManager.js#L359

       

        Attachments

          Activity

            People

            Assignee:
            cli@ocad.ca Cindy Qi Li
            Reporter:
            amb26 Antranig Basman
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: