Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      In the following detected situations settings transforms are filtered out when they shouldn't:

      1. Literal value transforms

      Due to not having any dependency in form of "inputPaths" this settings are optimized out. See https://github.com/GPII/universal/blob/master/gpii/node_modules/transformer/src/js/Transformer.js#L76.

      2. Settings with nested paths have their 'base path' wrongly inferred.

      The example here is the setting:

       "http://registry\\.gpii\\.net/applications/com
      .microsoft
      .windows
      .desktopBackgroundColor.SolidColor"

      when this settings is targeted with the payload:

      {
          "flat": {
              "name": "Daniel",
              "contexts": {
                  "gpii-default": {
                      "name": "Default preferences",
                      "preferences": {
                          "http://registry.gpii.net/applications/com.microsoft.windows.desktopBackgroundColor": {
                              "SolidColor": { "r": 67, "g": 187, "b": 19 }
                          }
                      }
                  }
              }
          }
      }
      

      The following settings path are inferred:

      The base path:

       
      "http://registry\\.gpii\\.net/applications/com\\.microsoft
      .windows

      .desktopBackgroundColor.SolidColor"
       
      is wrongly inferred to be a combination of two settings:
       
      "http://registry\\.gpii\\.net/applications/com\\.microsoft
      .windows

      .desktopBackgroundColor"
       
      and
       
      "SolidColor"
       
      Due to this, when trying to access the setting this operation will never succeed:

      https://github.com/GPII/universal/blob/master/gpii/node_modules/transformer/src/js/Transformer.js#L83

      Because the "supportedSettingsPath" will never match the string in the "actualSettingPaths".

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                cli@ocad.ca Cindy Qi Li
                Reporter:
                JJ JJ - Javier Jaramago Fernández
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: