Uploaded image for project: 'GPII - Global Public Inclusive Infrastructure'
  1. GPII - Global Public Inclusive Infrastructure
  2. GPII-49

Investigate and fix test case failure for SpiSettingsHandler

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None
    • Environment:

      Windows 7 x64, Windows XP

      Description

      The SpiSettingsHandler work for GPII-27 has been merged in for the 0.1 release, since it offers a very significant improvement on the current state of windows trunk and solves numerous other issues.

      However, there are still significant test case failures for the SpiSettingsHandler as committed on a variety of platforms - on my Windows 7 x64 machine, there is a failure of the HighContrast settings - this fails with error code 0 but with a return of 0 from the API call indicating failure.

      On testing on a Windows XP VM, in addition to the previous failure there is also a failure of the testNonClientMetrics case. Here is a full transcript of the failure on XP:

      jq: Test concluded - Module "SpiSettingsHandler Module" Test name "SpiSettingsHandler test - testFilterKeys
      ": 5/5 passed - PASS
      jq: FAIL: Module "SpiSettingsHandler Module" Test name "SpiSettingsHandler test - testHighContrast" - Messa
      ge: Assert testHighContrast: HighContrastTheme
      jq: Expected: High Contrast Black
      jq: Actual:
      jq: Source: at Object.jqUnit.assertEquals (S:\gits\gpii\node_modules\universal\node_modules\jqUnit\lib\
      jqUnit.js:61:11)
      jq: Test concluded - Module "SpiSettingsHandler Module" Test name "SpiSettingsHandler test - testHighContra
      st": 3/4 passed - FAIL
      jq: Test concluded - Module "SpiSettingsHandler Module" Test name "SpiSettingsHandler test - testStickyKeys
      ": 3/3 passed - PASS
      15:21:30.486: ASSERTION FAILED: SpiSettingsHandler.js: spi.getCurrentSettings() failed with error code 0.

      jq: FAIL: Module "SpiSettingsHandler Module" Test name "SpiSettingsHandler test - testNonClientMetrics" - M
      essage: Died on test #1: Object SpiSettingsHandler.js: spi.getCurrentSettings() failed with error code 0. ha
      s no method 'fail'
      jq: Source: at Object.fluid.fail (S:\gits\gpii\node_modules\universal\node_modules\infusion\src\webapp\
      framework\core\js\Fluid.js:79:21)
      jq: FAIL: Module "SpiSettingsHandler Module" Test name "SpiSettingsHandler test - testNonClientMetrics" - M
      essage: Expected 7 assertions, but 1 were run
      jq: Test concluded - Module "SpiSettingsHandler Module" Test name "SpiSettingsHandler test - testNonClientM
      etrics": 0/2 passed - FAIL
      jq: Test concluded - Module "SpiSettingsHandler Module" Test name "SpiSettingsHandler test - testLogFont":
      4/4 passed - PASS
      jq: Test concluded - Module "SpiSettingsHandler Module" Test name SpiSettingsHandler test - testMouseClick
      Lock": 2/2 passed - PASS
      jq: Test concluded - Module "SpiSettingsHandler Module" Test name "SpiSettingsHandler test - testMouse": 2/
      2 passed - PASS
      jq: ***************
      jq: All tests concluded: 19/22 total passed in 1422ms - FAIL
      jq: ***************

      Since these are core platforms for the portability profile of GPII windows, we should investigate and resolve these failures as a matter of urgency, even as the interim 0.1 release of GPII is shipping with them.

        Activity

        Hide
        kasper Kasper Markus added a comment -

        As of 16/01/2012, under windows 7, the test output is as follows:

        jq: Test concluded - Module "SpiSettingsHandler Module" Test name "SpiSettingsH
        andler test - testFilterKeys": 5/5 passed - PASS
        ASSERTION FAILED: SpiSettingsHandler.js: spi.applySettings() failed with error
        code 998.
        jq: FAIL: Module "SpiSettingsHandler Module" Test name "SpiSettingsHandler test

        • testHighContrast" - Message: Died on test #1: SpiSettingsHandler.js: spi.appl
          ySettings() failed with error code 998.
          jq: Source: at C:\Users\kasper\gpii\node_modules\universal\gpii\node_module
          s\gpiiFramework\utils.js:38:19
          jq: FAIL: Module "SpiSettingsHandler Module" Test name "SpiSettingsHandler test
        • testHighContrast" - Message: Expected 4 assertions, but 1 were run
          jq: Test concluded - Module "SpiSettingsHandler Module" Test name "SpiSettingsH
          andler test - testHighContrast": 0/2 passed - FAIL
          jq: Test concluded - Module "SpiSettingsHandler Module" Test name "SpiSettingsH
          andler test - testStickyKeys": 3/3 passed - PASS
          jq: Test concluded - Module "SpiSettingsHandler Module" Test name "SpiSettingsH
          andler test - testNonClientMetrics": 7/7 passed - PASS
          jq: Test concluded - Module "SpiSettingsHandler Module" Test name "SpiSettingsH
          andler test - testLogFont": 4/4 passed - PASS
          jq: Test concluded - Module "SpiSettingsHandler Module" Test name "SpiSettingsH
          andler test - testMouseClickLock": 2/2 passed - PASS
          jq: Test concluded - Module "SpiSettingsHandler Module" Test name "SpiSettingsH
          andler test - testMouse": 2/2 passed - PASS
          jq: ***************
          jq: All tests concluded: 23/25 total passed in 797ms - FAIL
          jq: ***************
        Show
        kasper Kasper Markus added a comment - As of 16/01/2012, under windows 7, the test output is as follows: jq: Test concluded - Module "SpiSettingsHandler Module" Test name "SpiSettingsH andler test - testFilterKeys": 5/5 passed - PASS ASSERTION FAILED: SpiSettingsHandler.js: spi.applySettings() failed with error code 998. jq: FAIL: Module "SpiSettingsHandler Module" Test name "SpiSettingsHandler test testHighContrast" - Message: Died on test #1: SpiSettingsHandler.js: spi.appl ySettings() failed with error code 998. jq: Source: at C:\Users\kasper\gpii\node_modules\universal\gpii\node_module s\gpiiFramework\utils.js:38:19 jq: FAIL: Module "SpiSettingsHandler Module" Test name "SpiSettingsHandler test testHighContrast" - Message: Expected 4 assertions, but 1 were run jq: Test concluded - Module "SpiSettingsHandler Module" Test name "SpiSettingsH andler test - testHighContrast": 0/2 passed - FAIL jq: Test concluded - Module "SpiSettingsHandler Module" Test name "SpiSettingsH andler test - testStickyKeys": 3/3 passed - PASS jq: Test concluded - Module "SpiSettingsHandler Module" Test name "SpiSettingsH andler test - testNonClientMetrics": 7/7 passed - PASS jq: Test concluded - Module "SpiSettingsHandler Module" Test name "SpiSettingsH andler test - testLogFont": 4/4 passed - PASS jq: Test concluded - Module "SpiSettingsHandler Module" Test name "SpiSettingsH andler test - testMouseClickLock": 2/2 passed - PASS jq: Test concluded - Module "SpiSettingsHandler Module" Test name "SpiSettingsH andler test - testMouse": 2/2 passed - PASS jq: *************** jq: All tests concluded: 23/25 total passed in 797ms - FAIL jq: ***************
        Hide
        tsakov Evgeni Tsakov added a comment -

        You can track the progress here - https://github.com/tsakov/windows/tree/gpii-49

        Show
        tsakov Evgeni Tsakov added a comment - You can track the progress here - https://github.com/tsakov/windows/tree/gpii-49
        Hide
        tsakov Evgeni Tsakov added a comment - - edited

        I solved the problem with High Contrast on Windows 7 64-bit. It was an issue with the operating system rather than the SpiSettingsHandler.

        solution: http://support.microsoft.com/kb/2516889

        fast download link:
        http://windows-update-checker.com/hotfix/x64/Client and Server/Windows6.1-KB2516889-x64.msu

        I had the same test output as Kasper. After installing the hotfix all tests ran successfully.

        Show
        tsakov Evgeni Tsakov added a comment - - edited I solved the problem with High Contrast on Windows 7 64-bit. It was an issue with the operating system rather than the SpiSettingsHandler. solution: http://support.microsoft.com/kb/2516889 fast download link: http://windows-update-checker.com/hotfix/x64/Client and Server/Windows6.1-KB2516889-x64.msu I had the same test output as Kasper. After installing the hotfix all tests ran successfully.
        Hide
        amb26 Antranig Basman added a comment -

        Thanks Evgeni for this great piece of detective work - I have acquired the hotfix and verified that the test cases will indeed pass with it, this work has been committed as part of the coordinated GPII-105 commits. I have updated the README files to contain a pointer to this hotfix which we will need to find a strategy for distributing wherever the GPII goes on Windows.

        Show
        amb26 Antranig Basman added a comment - Thanks Evgeni for this great piece of detective work - I have acquired the hotfix and verified that the test cases will indeed pass with it, this work has been committed as part of the coordinated GPII-105 commits. I have updated the README files to contain a pointer to this hotfix which we will need to find a strategy for distributing wherever the GPII goes on Windows.
        Hide
        amb26 Antranig Basman added a comment - - edited

        Unfortunately Microsoft have in the last couple of weeks changed their distribution policy on hotfixes, and no longer offer a direct download either via the KB issue or the link you supplied - one now has to pass a gauntlet consisting of a CAPTCHA followed by an emailed patch

        I do still find it at http://thehotfixshare.net/board/index.php?autocom=downloads&showfile=13393 but this is probably not with the approval of Microsoft.

        Show
        amb26 Antranig Basman added a comment - - edited Unfortunately Microsoft have in the last couple of weeks changed their distribution policy on hotfixes, and no longer offer a direct download either via the KB issue or the link you supplied - one now has to pass a gauntlet consisting of a CAPTCHA followed by an emailed patch I do still find it at http://thehotfixshare.net/board/index.php?autocom=downloads&showfile=13393 but this is probably not with the approval of Microsoft.
        Hide
        kasper Kasper Markus added a comment -

        Closing as these were resolved more than a year ago and haven't been updated since

        Show
        kasper Kasper Markus added a comment - Closing as these were resolved more than a year ago and haven't been updated since

          People

          • Assignee:
            kasper Kasper Markus
            Reporter:
            amb26 Antranig Basman
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: