Uploaded image for project: 'GPII - Global Public Inclusive Infrastructure'
  1. GPII - Global Public Inclusive Infrastructure
  2. GPII-49

Investigate and fix test case failure for SpiSettingsHandler

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None
    • Environment:

      Windows 7 x64, Windows XP

      Description

      The SpiSettingsHandler work for GPII-27 has been merged in for the 0.1 release, since it offers a very significant improvement on the current state of windows trunk and solves numerous other issues.

      However, there are still significant test case failures for the SpiSettingsHandler as committed on a variety of platforms - on my Windows 7 x64 machine, there is a failure of the HighContrast settings - this fails with error code 0 but with a return of 0 from the API call indicating failure.

      On testing on a Windows XP VM, in addition to the previous failure there is also a failure of the testNonClientMetrics case. Here is a full transcript of the failure on XP:

      jq: Test concluded - Module "SpiSettingsHandler Module" Test name "SpiSettingsHandler test - testFilterKeys
      ": 5/5 passed - PASS
      jq: FAIL: Module "SpiSettingsHandler Module" Test name "SpiSettingsHandler test - testHighContrast" - Messa
      ge: Assert testHighContrast: HighContrastTheme
      jq: Expected: High Contrast Black
      jq: Actual:
      jq: Source: at Object.jqUnit.assertEquals (S:\gits\gpii\node_modules\universal\node_modules\jqUnit\lib\
      jqUnit.js:61:11)
      jq: Test concluded - Module "SpiSettingsHandler Module" Test name "SpiSettingsHandler test - testHighContra
      st": 3/4 passed - FAIL
      jq: Test concluded - Module "SpiSettingsHandler Module" Test name "SpiSettingsHandler test - testStickyKeys
      ": 3/3 passed - PASS
      15:21:30.486: ASSERTION FAILED: SpiSettingsHandler.js: spi.getCurrentSettings() failed with error code 0.

      jq: FAIL: Module "SpiSettingsHandler Module" Test name "SpiSettingsHandler test - testNonClientMetrics" - M
      essage: Died on test #1: Object SpiSettingsHandler.js: spi.getCurrentSettings() failed with error code 0. ha
      s no method 'fail'
      jq: Source: at Object.fluid.fail (S:\gits\gpii\node_modules\universal\node_modules\infusion\src\webapp\
      framework\core\js\Fluid.js:79:21)
      jq: FAIL: Module "SpiSettingsHandler Module" Test name "SpiSettingsHandler test - testNonClientMetrics" - M
      essage: Expected 7 assertions, but 1 were run
      jq: Test concluded - Module "SpiSettingsHandler Module" Test name "SpiSettingsHandler test - testNonClientM
      etrics": 0/2 passed - FAIL
      jq: Test concluded - Module "SpiSettingsHandler Module" Test name "SpiSettingsHandler test - testLogFont":
      4/4 passed - PASS
      jq: Test concluded - Module "SpiSettingsHandler Module" Test name SpiSettingsHandler test - testMouseClick
      Lock": 2/2 passed - PASS
      jq: Test concluded - Module "SpiSettingsHandler Module" Test name "SpiSettingsHandler test - testMouse": 2/
      2 passed - PASS
      jq: ***************
      jq: All tests concluded: 19/22 total passed in 1422ms - FAIL
      jq: ***************

      Since these are core platforms for the portability profile of GPII windows, we should investigate and resolve these failures as a matter of urgency, even as the interim 0.1 release of GPII is shipping with them.

        Attachments

          Activity

            People

            • Assignee:
              kasper Kasper Markus
              Reporter:
              amb26 Antranig Basman
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: