Uploaded image for project: 'GPII - Global Public Inclusive Infrastructure'
  1. GPII - Global Public Inclusive Infrastructure
  2. GPII-671

Remove ".set" in the settingshandler types of the solution registry

    XMLWordPrintable

    Details

    • Type: Task
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: Solution Registry
    • Labels:
      None

      Description

      Currently, when declaring the type of a settingshandler used in the entries of the solution registry, the requirement is that the full namespace of that settingshandler, suffixed by ".set" is used, as shown here: https://github.com/GPII/universal/blob/908c8362e4b43a8c15bb88f37dd2e4eef8ca1790/testData/solutions/win32.json#L60

      Since the contract of all settingshandlers is that they must support a ".get" and ".set" function, this seems unnecessary. Instead it would be better if the settingshandler used was declared without the ".set". So in the example linked above, the type declared would be: "type": "gpii.settingsHandlers.XMLHandler"

      The motivation for avoiding the ".set" part is that it then becomes a lot easier to use the ".get" functionality of the settingshandlers of a given solution. As it is now, one needs to do a substring to subtract the ".set" part of the string. Instead one should be able to use the type directly and append the ".set" or ".get" when appropriate.

        Attachments

          Activity

            People

            Assignee:
            kasper Kasper Markus
            Reporter:
            kasper Kasper Markus
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: